Core - Use fnc_getDescriptiveName for all ACE Action Names#1372
Merged
jonpas merged 12 commits intoIDI-Systems:masterfrom Feb 4, 2025
Merged
Core - Use fnc_getDescriptiveName for all ACE Action Names#1372jonpas merged 12 commits intoIDI-Systems:masterfrom
fnc_getDescriptiveName for all ACE Action Names#1372jonpas merged 12 commits intoIDI-Systems:masterfrom
Conversation
Member
|
Agreed! |
jonpas
approved these changes
Feb 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When merged this pull request will:
sys_core_fnc_getDescriptiveNamein favour offormat ["%1 Chn: %2", _radioName, api_fnc_getRadioChannel].I noticed yesterday that the GSA action to connect a PRC-77 displayed the radio's frequency as
[MHzKnobPos, KHzKnobPos], sinceapi_fnc_getRadioChannelreturns that raw data in its case.getDescriptiveName's return is IMO better in all situations, as it will properly format channel data for all radios and also display useful info like the PTT number.Bk x Ch yinstead of the absolute (overflowing) channel number.switchChannelFasthint) to show H and P channels as letters instead of numbers.x MHzin HW mode andChn x NetID yin AKW mode.30.00 MHzfor the PRC-77 and30.000 MHzfor the SEM 70 (in HW mode).